Html, css,js

Community feedback

• 

  Antoine•220

  @Antoine-FloPosted about 4 years ago

  Hi TheMihir 👋 good job, your design comparison looks nice.

  Anyway, your layout isn't responsive right now, you have to find ways to fix your design so it doesn't move everywhere when the screen size changes.

  • Float properties are nice but you should also use flexbox, to help you organize your elements with more control.
  • Apply a max-width to your container so it doesn't stretch on big screens
  • I wouldn't use the bg-pattern-desktop as a background-image, but as an img in your html, like the woman (with absolute positioning).
  • Notice that the 'woman' picture changes when in mobile size. You don't have to use the box anymore but the other illustration in you images folder.

  Keep coding, layouts are challenging at first but it gets easier 👍

  2

  ---

  

  TheMihir•85

  @TheMihirSenseiPosted about 4 years ago

  @Antoine-Flo thanks man really need this kind of feedback. that's actually means to give feedback.I will improve soon as possible thanks again.

  1