Design comparison
Community feedback
- @tobezhanabiPosted over 1 year ago
Hi, Nice job you did very well
Work on HTML
You should replace the <div class="card"> with the landmark <main> this way your site gets accessibility. It is not important for this fragment of a site, but by making it in a habit, you can easily build crawl-able site. Landmarks in HTML are structural elements that define the major sections of a webpage. They include semantic elements such as <header>, <nav>, <main>, <article>, <aside>, and <footer>
Heading
Generally, it is a best practice to ensure that the beginning of a page's main content starts with a h1 element, and also to ensure that the page contains only one h1 element.
You should always have h1 tag on your site, and they should follow the hierarchical order. i.e. h1> h2> h3 till h6
Overall, you did a fantastic job,
happy coding
Marked as helpful0@bacigala25Posted over 1 year ago@tobezhanabi Thanks for advices. Of course i will try use the right landmarks in future.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord