HTML CSS3 Flex-Box

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, great job on this one and congrats as well for you first fem challenge! The layout looks great in general.

  Some suggestions would be:

  • Always have a main element to wrap the main content of your site. This helps users to properly navigate the page. On this one, the .wrapper selector could have used main element instead of div.
  • The alt value for the vector image should be left empty like alt="" and add an aria-hidden="true" attribute on it as well. When an image acts only as a decoration, use those mentioned, but if the image adds content to the site, then use a meaningful alt value.
  • When using alt attribute, avoid using words that relates to "graphic" such as "illustration, image, logo.." since it is already an image, no need to describe it as one.
  • Always have an h1 on a page, for this one, the order summary could be h1 for now, but really it is not great to be h1, so if I were to tackle this challenge, I would make the h1 an sr-only text, you could look that one up on the net.
  • Music icon should be using alt="" and aria-hidden="true" added on it.

  Aside from those, the site looks great and congrats again on this one.

  Marked as helpful

  1

  ---

  

  Jan Lingott•25

  @zlsNormanPosted about 3 years ago

  @pikamart
  thanks for your feedback and suggestions.

  i adjusted my code, but i used a non Bootstrap sr-only.

  0