HTML CSS

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi @CalebeSobrinho, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  I saw that for some properties you’ve used rem and for others px. In this case, it is better to use only one kind of unit to have a better organization for your code. relative units as rem or em have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.

  Clean your code by removing some unnecessary divs, most of the content can stand alone without a div. Use div only for blocks that need a special alignment or the content needs a special positioning.

  Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.

  Something that can be a time saver for you is to use a CSS RESET to remove all default settings for margins, making the images easier to work, see the article below where you can copy and paste this CSS code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0
• 

  Cdric2Leroy•30

  @C2dricLeroyPosted about 2 years ago

  Very nice project and very clean ! So close to the original !

  I just have one little recommandation : On line 63 in your style.css, you wrote .attirbution instead of .attribution

  Hope it will help you ! :)

  0

  ---

  

  Calebe Sobrinho•20

  @CalebeSobrinhoPosted about 2 years ago

  @C2dricLeroy Thank youu!

  0