HTML, CSS with Flexbox and Grid, and JS

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  Hey Eloisa, congrats on submitting your first solution. It looks really good! 👍

  Here are a couple of small pointers after taking a look at your code:

  • Your overall HTML structure is great. The one thing I'd recommend changing is the article element. article is typically used for self-contained content, such as a news article, blog post, or forum post. You can read more about the article element on MDN. In this instance, I'd say the main element might be a better option. This is only a small point though 🙂
  • I'd also recommend not using IDs for styling. They're overly specific and cannot be reused on the page. Instead, I'd stick to class, attribute, pseudo, or type selectors.

  I hope these tips help. Keep up the great work!

  0

  ---

  

  Eloisa•160

  @eefborromeoPosted about 5 years ago

  @mattstuddert Hi Matt, thanks for the feedback. I'll be updating this project with these tips. Looking forward to doing more challenges!

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  @eefborromeo great! Looking forward to seeing your next project!

  0