HTML CSS With A Responsive Page

Community feedback

• 

  Doston Nabotov•950

  @dostonnabotovPosted over 1 year ago

  Hi, there!

  Congrats on completing the challenge.

  Here are some suggestions I would like to make:

  • If you want to write a robust and better maintainable code, focus on naming things.

  Instead of this:

  <button class="send">Send</button>
  <button class="cancel">Cancel</button>
  

  Try switching it to this:

  <button class="button" data-type="primary">Send</button>
  <button class="button" data-type="ghost">Cancel</button>
  

  Even if your project scales (in this case, it doesn't), you don't end writing the same code over and over again.

  • Don't nest too much.

  main .container .plans .text p {}
  

  That's way too much nesting. Even if you're writing your code in Sass or Less (with less care about the output), your CSS ends up looking like a crap. Also, it can have impact on CSS specificity.

  Expect these problems, everything looks good to me.

  Good luck on your coding journey!

  Marked as helpful

  1