@Bishalsnghd07
Posted
Hi, @snakechickensoup👋
Congrats for completing this challenge 🎉 and you did a great job👏
1)Semantic HTML is okay but, you did a extra things on footer by adding section, that is breaking your semantic ui, no need of section there. You simply just give div there or only paragraph tag is enough
2)There is a one issue in your CSS basics, never ever give height
in the body tag. It will only break your layout. You can directly give min-height
instead of height
.
Hope, this small tips will help you in further projects too!
Once again Welcome to Frontend Mentor wishing you a very joyful journey ahead and Happy Coding❤️
Marked as helpful