Skip to content
Submitted 8 months ago

HTML, CSS

mijeong•160
@snakechickensoup
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I want to write HTML tags in a semantic way.

What challenges did you encounter, and how did you overcome them?

I used Google to search for solutions when implementing shadows.

What specific areas of your project would you like help with?

I want to know how to write clean.

Community feedback

  • Bishal Singh Deo🎮•1,440
    @Bishalsnghd07Posted 8 months ago

    Hi, @snakechickensoup👋

    Congrats for completing this challenge 🎉 and you did a great job👏

    1)Semantic HTML is okay but, you did a extra things on footer by adding section, that is breaking your semantic ui, no need of section there. You simply just give div there or only paragraph tag is enough

    2)There is a one issue in your CSS basics, never ever give height in the body tag. It will only break your layout. You can directly give min-height instead of height.

    Hope, this small tips will help you in further projects too!

    Once again Welcome to Frontend Mentor wishing you a very joyful journey ahead and Happy Coding❤️

    Marked as helpful
    0
  • mijeong•160
    @snakechickensoupPosted 8 months ago

    Thank you for pointing out the issue. I'll make sure to keep it in mind for future reference.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord