Skip to content
Submitted over 3 years ago

HTML, CSS, Vanilla JS

Yash Parekh•20
@yash20010
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Tip calculator app
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

Any improvements or optimizations are welcome.

Community feedback

  • Marius Fagerland•125
    @mariusfaPosted over 3 years ago

    Hi!

    Your labels and inputs are not semantic correct. Labels should not be h3. Correct semantic way is:

    <label for="bill" class="myLabel">Bill</label>
<input name="bill" type="number"/>

    Label and input should be together with a for/name. This also helps for automatic e2e tests like playwright/selenium.

    Also notice the type="number". This will bring the correct keyboard for phones.

    Otherwise nice job

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord