html css

Community feedback

• 

  Caleb Bankole•230

  @BankoleCalebPosted over 1 year ago

  Well done on your first project!🎉🎉🥳

  First, I'd like to tell you that you don't need flexbox on the div. You only needed it on the body for centering. Also, using semantic HTML could have improved the accessibility of your site. Furthermore, the page is not responsive.

  You didn't have to use more than one CSS file as you have done; you could have just used media query. With what you have done, no style is applied on small screen - confirm that.

  I hope you find this helpful. Continue on journey; we'll meet at the top!

  Marked as helpful

  0

  ---

  

  Miguel Olarte•20

  @Olarte910903Posted over 1 year ago

  @BankoleCaleb I am very happy to have met this platform, I want to thank you for the advice, this helps me a lot to learn and become a good developer, I am very grateful to you and I am going to improve my code

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

  ---

  QR iMAGE ALT TEXT 📸:

  • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.

  ---

  • The alt with qr-code is not even explaining for what the QR image need to be used.

  ---

  • So update the alt with meaningful text which explains like QR code to frontendmentor.io

  ---

  Example

  <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Miguel Olarte•20

  @Olarte910903Posted over 1 year ago

  @0xAbdulKhalid Hello, I am very grateful to you for sharing your knowledge with me and helping me improve, believe me that I still have a lot to learn, but I really want to learn everything as it should be in the correct way, and I am very grateful to you for helping me improve my code, I keep in mind all the comments to improve my code

  0