Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML, CSS to create QR code component

P
Julie 130

@jclegg31

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


It went pretty well. I got a little hung up on the min-height: 100vh; part and how it wouldn't center top to bottom until I added a border and saw that it was centered but I wasn't giving it the full height. I don't have any questions but would love any feedback if anyone had some. Thanks!

Community feedback

Ecem Gokdogan 9,380

@ecemgo

Posted

Some recommendations regarding your code that could be of interest to you.

In order to fix the accessibility issues:

  • You need to replace <div class="container"> with the <main class="container"> tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.
  • Each main content needs to include at least h1 element so you should use one <h1> element in the <main> tag. You can replace your <h2>Improve your front-end skills by building projects</h2> element with the <h1>Improve your front-end skills by building projects</h1> element.

After committing the changes on GitHub and you need to deploy it as a live site. Finally, you should click generate a new report on this solution page to clear the warnings.

Hope I am helpful. :)

Marked as helpful

0

P
Julie 130

@jclegg31

Posted

@ecemgo thanks again for the feedback, made some updates as I get back into FEM! Super helpful!

1
Ecem Gokdogan 9,380

@ecemgo

Posted

@jclegg31 I'm happy to help!

0
Fer 3,970

@fernandolapaz

Posted

Hi 👋, I leave this here in case you want to take a look:

HTML 🧱, ACCESSIBILITY ⚖:

🔹Semantic elements:

The main content of every document (the whole card in this case) should be wrapped with the <main> tag.

Also, there is no reason to skip headings, and every page should have an <h1>.

CSS 🎨:

🔹Length units such as pixels may not be the best alternative because screen sizes and user preferences vary, and absolute units don’t scale. Relative units like em or rem are a better option for scalable layouts (the page will adjust to the user's browser settings) and maintenance (to make changes without having to adjust every pixel value).

If you have any questions I’m here to answer so don't hesitate 🙂

Regards,

Marked as helpful

0

P
Julie 130

@jclegg31

Posted

@fernandolapaz thanks so much, super helpful!!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord