Design comparison
SolutionDesign
Solution retrospective
Please comment on the code quality as well as how this can be improved further and some more resources to learn stuff.
Community feedback
- @SzymonRojekPosted almost 4 years ago
Hi Sarvesh,
Well done, I have used last time the tailwind. What do you think about this technology? Do you like it?
I have checked your HTML structure, a few tips below:
- check accessibility & HTML issues in a report above and try to fix it;
- I'd recommend using semantic tags in this project (check it out why they matter), for example: instead of divs using for texts I'd suggest to use the p tag;
- I'd suggest adding heading;
- you can add RWD for tablets => start from mobile with one column, then two rows with two boxes each and the 5th box below on the entire length of the container, finally the desktop design pattern.
Ps. Don't forget to upvote any comments on here that you find helpful.
Greetings :D
1 - @ApplePieGiraffePosted almost 4 years ago
Hello there, Sarvesh Dubey! 👋
Nice job on this challenge! 👏 Your solution looks pretty good!
I'd like to suggest,
- Decreasing the overall size of the project in the desktop layout (things seem a little large, then).
- Adding a
max-width
to the grid of the page to prevent the content of the page from becoming too wide on extra-large screens. - Like SzymonRojek mentioned, adding a tablet layout would be a good idea! 😉
- Adding some
alt
attributes to the images on the page to clear up your solution report and make your solution more accessible.
Keep coding (and happy coding, too)! 😁
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord