HTML CSS

Community feedback

• 

  darryncodes•6,370

  @darryncodesPosted over 3 years ago

  Hi Khadeejathul,

  Really great work on the desktop version.

  A few suggestions from me:

  • you could add your border style border: 1px solid hsla(0, 0%, 100%, 0.75);} to the <button> styles to stop it from jumping when it is hovered
  • I'd try transition: ease-in .3s; to your <button> styles. It'll make the hover affects less abrupt
  • you could try using a media query at a mobile break point and set the flex-direction to column for a responsive mobile layout: @media only screen and (max-width: XXXpx) { .container { flex-direction: column; } }
  • your semantic html looks pretty good. however your .attribution <div> could be a <footer>. This should resolve the only warning in the accessibility report

  Good luck!

  Marked as helpful

  1

  ---

  

  Khadeejathul Humaira .M.S•60

  @KhadeejathulHumairaPosted over 3 years ago

  @darryncodes Thank you , I will correct them

  0