Design comparison
Solution retrospective
Hello. This is my second independent project. For convenience, look at the styles in the file style.scss. Tried to work with preprocessor (scss) for the first time.
Is the code readable, is everything correct, in your opinion? I will be glad to comments and criticism. Thanks :)
Community feedback
- @parthjain0Posted about 3 years ago
the page looks quite good..try to use rem units over pixels as it saves a lot of headache while making the page responsive...also never give heights in px as it causes text to overflow on smaller screens
Marked as helpful0@EugiSsPosted about 3 years ago@parthjain98 Good thought about rem. Do you mean that it is worth specifying the height in any unit other than px? Thanks for the advice
0@DhaneylPosted about 3 years ago@EvgiSs If you want a website more flexible for mobiles and computers, it's commendable to use rem.
Marked as helpful0@parthjain0Posted about 3 years ago@EvgiSs if u want a certain section to have height the only way i would suggest is by giving it in % or vh and that too for min height so that when text goes beyond the div..ie on smaller screens the section increases in size vertically..hopefully im able to make sense
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord