Design comparison
SolutionDesign
Solution retrospective
Hey everyone
Please check my solution and provide suggestions.
Thank you
Community feedback
- @darryncodesPosted over 3 years ago
Hi Bhupender,
Excellent solution, well done.
Some considerations:
- use semantic html. your
.container
<div>
could be<main>
and your.attribution
<div>
could be<footer>
. This should resolve the warnings in the accessibility report - I usually like to add transition:
ease-in .3s;
to buttons. Add it to your.learn
styles. It'll make the hover affect less abrupt.
Marked as helpful1 - use semantic html. your
- @palgrammingPosted over 3 years ago
You should remove that min width out of your media query
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord