HTML CSS SASS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey there, Yagiz! 👋

  Nice to see you complete another challenge! 😀 Well done on this one! 👍

  I just suggest adding min-height: 100vh to the body (to make sure that it is always at least as high as the viewport) and setting background-size to the cover for the background image (to make sure that it fills the entire area of the screen) in both the desktop and mobile layouts. 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Yagiz•140

  @tosbaaPosted almost 4 years ago

  @ApplePieGiraffe Thank you so much for the feedbacks !!

  1
• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 4 years ago

  Hey Yagiz, nice work on this challenge! It looks like you might have updated your code since the first report was generated, so if you go to the report page and click "Generate new report" it should clear those error messages.

  The Register call-to-action looks fine to me. There's a slight transition on it, which is very common, so that might be what you're seeing (but I could be wrong).

  As for your code, it all looks good. The one thing I'd recommend in your HTML would be to add anchor tags for the social media icons. You'd expect these to be clickable if this was a real site, so anchor tags make sense.

  I'd also recommend reviewing your layout at tablet sizes (around 660px and above) as the content looks a bit squashed.

  I hope that helps. Keep up the great work! 👍

  1

  ---

  

  Yagiz•140

  @tosbaaPosted almost 4 years ago

  @mattstuddert Thank you so much for the feedback. Noted them all !!

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 4 years ago

  @tosbaa you're welcome!

  0
• 

  Yagiz•140

  @tosbaaPosted almost 4 years ago

  Changed the min-width for grid elements

  0