HTML, CSS, SASS

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Your **HTML should have ** a main element that will assist in identifying the main content of your site. In this, case the main element would serve as the "container" of your component.

  More Info:📚

  MDN Main Element

  • Since the image in this component add value and serve a purpose it needs to be accessible. The image needs to be applied using the image element and not the background-image property, as it will let apply an alt tag description to image stating what the image is and where it leads to.

  • The width: 100%; is not needed in the body since it is already 100% by default. you will also change the height: 100vh; to min-height: 100vh; for better responsiveness.

  • Change width to max-width in your component’s container to make it responsive. You will also want to remove the height as it is unnecessary.

  • Change width to max-width: 100% in your image to make it responsive. You will also want to remove the height as it is unnecessary.

  • For improved accessibility 📈 for your content, it is best practice to use rem for your property values. Using this unit gives users the ability to scale elements up and down, relative to a set value.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  0