HTML, CSS, SASS, CSS flexbox

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi Tykhomyrov Oleksandr,

  Congratulation on completing this frontend mentor challenge. Your solution looks great. I have some suggestions regarding your solution:

  • You should use <main> landmark to wrap the card. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.

  • In my opinion, the image is an important content. The alternate text is needed on this image. The alternate text should indicate where the Qr code navigate the user : like QR code to frontend mentor not describes the image.

  • Adding max-width on the body tag to prevent layout from stretching. If you try to zoom out on your browser , you'll see that the layout stretches, adding max-width will prevent that. Personally, I don’t restrict the width of the body element. If I need to restrict the width I use a container div with a max-width on it.

  Hopefully this feedback helps.

  Marked as helpful

  1

  ---

  

  Tykhomyrov Oleksandr•110

  @alex1991tikhomirovPosted about 2 years ago

  @PhoenixDev22 thank you. Great feedback. I will get it right in the next project

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @alex1991tikhomirov

  Glad to help. Happy coding!

  1
• 

  imad•3,330

  @imadvvPosted about 2 years ago

  Greeting Tykhomyrov Oleksandr!! Congratulations on completing your challenge!, 👏👏👏

  try answering your question, they are a lot of alternative ways, but i think the most ideal way is Grid, you can do something like this.

  .container {
  display : grid;
  place-content: center;
  }
  

  or

  .container {
  display : grid;
  place-items: center;
  }
  

  Hope this give you some hint!!

  Happy Codding, Have a Great Day

  Marked as helpful

  1

  ---

  

  Tykhomyrov Oleksandr•110

  @alex1991tikhomirovPosted about 2 years ago

  @imadbg01 thanks for the advice. I appreciate it.

  1

  

  imad•3,330

  @imadvvPosted about 2 years ago

  @alex1991tikhomirov You're welcome my friend,

  1