Submitted almost 2 years ago

HTML, CSS, Sass

Dorian• 140

@dkirinc

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

News homepage

HTML
CSS
JS

2junior

View challenge

Design comparison

SolutionDesign

Solution retrospective

Greeting to all the Frontend mentor community,

this is my first solution and I would want to ask few questions about your setup.

If design is made in 1440px do you adjust your browser element inspector to that size and do your programming or just insert everything to a div class "container" with max width of 1440px
I had a little problems with defining the height of my headings and paragraphs, is there some kind of a trick or something to get this problem solved easier
Any comment to this deployment is welcome, I am starting something new so I am aware that errors while making are going to be normal

Community feedback

Lord Robins• 550

@ZenitsuAg

Posted almost 2 years ago

Hi Dorlan, you've done a really great job. Here are so tips to help you improve your code

If the design is made at 1440px then all you have to do is to set the max-width property of the main element to 1440px.
Also its better to wrap the entire code in a main tag.
Heading tags should also increase in a logical order, that is h2 after h1, h3 after h2 like that. This is because of screen readers to make the page easy to navigate. You can read more about it here.
And as for defining the height of heading, paragraphs etc I also struggle with that, sometimes I just use a ruler to get it right. But we can consult @AdrianoEscarabote for more insights.

Marked as helpful

Dorian• 140

@dkirinc

Posted almost 2 years ago

Hey @ZenitsuAg,

thank you for the comment. It cleared up a few things for me :)

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord