Skip to content
Submitted over 2 years ago

html , css

Pratyusha Majumder•280
@FloraBloomblue
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I want to know is my code acceptable? It's my first time attempting projects on site and submitting challenges.

Community feedback

  • riverCodes•300
    @riverCodesPosted over 2 years ago

    Hi, good job on the challenge! You have nailed the inner contents of the card. A few suggestions:

    1. to fix your Accessibility issues, first change your div.rectangle-box to a <main> tag. (main.rectangle-box) Secondly, your page should always have one <h1> element.
    2. You probably want to center your main component vertically on the page. To do this, apply the following styles to your <body>
    min-height: 100vh; (this forces your <body> tag height to be 100% of the viewport height, by default element heights depend upon the inner content size, unlike width.)
display: flex;
flex-direction: column;
justify-content: center;

    hope this helps, good job once again :D

    Marked as helpful
    1
    Pratyusha Majumder•280
    @FloraBloombluePosted over 2 years ago

    @riverCodes Hello there, Firstly, a huge thankyou for the correction you suggested, I have implemented them . As I have already submitted once, So can I submit my code again after correcting it?

    1
    riverCodes•300
    @riverCodesPosted over 2 years ago

    @FloraBloomblue

    • if you have created a git commit, and pushed it to your online repository, your live site should reflect those changes after like 5 minutes.

    • As for frontend-mentor if you go to your solution hub, on the top right you will see a tab called update solution, and there you can update stuff.

    • Also, if you click on view report under the HTML and Accessibility issues, you will see a generate new report option, you can click that and it will analyze your new code and it should show no issues.

    Marked as helpful
    0
    Pratyusha Majumder•280
    @FloraBloombluePosted over 2 years ago

    @riverCodes Thank You so much

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord