Design comparison
SolutionDesign
Solution retrospective
How does this look? Does the code look professional?
Community feedback
- Account deleted
Hi, here are some suggestions:
- Correct the URL to the repository of this project, currently it sends me to another one. 😁
- Uses semantic HTML; you can change the
div
of the card tosection
orarticle
; and thediv
of the frame byfigure
- You've removed accessibility, for example, when you do
[Tab]
on your page shouldfocus
on the links, that doesn't happen 😟 - The same with attribution links, why did you change the cursor? The cursor you have placed indicates text, nothing to do with links
I hope this is helpful, happy coding! 😀
1@ShunlexxiPosted about 1 year agoHi @mendez-v,
Thanks for taking your time to review this. I'll definitely work on these suggestions.
Regards
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord