Submitted 10 months ago
HTML, CSS responsive.
@JonathanJimenezTrivin0
Design comparison
SolutionDesign
Solution retrospective
Gracias por los comentarios.
Community feedback
- @AGutierrezRPosted 10 months ago
Hello there 👋. Good job on completing the challenge!
I have some suggestions about your code that might interest you.
CSS and Styling:
- Avoid using
px
forfont-size
, you could read this article to learn why. Letter spacing and line height must not be inpx
, userem
for all the font-related properties. - Instead of fixed widths, employ
max-width
andmin-width
for flexible and responsive design. - Let the content decide the height of the elements. Use padding and margins strategically for this purpose.
Accessibility and Semantic HTML:
- Profile image could benefit from a more descriptive alt text, like
alt="Headshot of Greg Hooper"
or you could leave it emptyalt=""
.
I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!
Happy coding!
Marked as helpful0 - Avoid using
- @JonathanJimenezTrivin0Posted 10 months ago
Hola Andrés muchas gracias por el comentario, lo tendré en cuenta para futuros proyectos :).
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord