Design comparison
Solution retrospective
What did you find difficult while building the project? That would be position the cards ๐
Do you have any questions about best practices? "Px" or "Rem" any advantage or disadvantage?
Does the codebase looks professional?
Community feedback
- @MelvinAguilarPosted about 1 year ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
-
px
is an absolute unit, meaning it stays fixed regardless of the user's preferences. On the other hand,rem
is a relative unit, specifically relative to the root element's font size Disadvantages ofpx
:- Pixel-based designs may not scale well when users adjust the font size in their browsers, potentially impacting accessibility.
- Designs in pixels might not be as responsive to varying screen sizes
Disadvantages of
rem
:- Calculations involving "rem" can be more complex.
-
Positioning elements with
position: absolute
can lead to significant issues. If you zoom in on your solution, parts might distort, separate, or overlap. It would be beneficial to use a grid for creating two columns and utilize flexbox or grid for centering to avoid these problems
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
1@ShunlexxiPosted about 1 year agoHi @MelvinAguilar ,
Thanks a lot for taking out time to write this! And for recommending "grid" honestly, I just didn't think about it. I'll try implementing that. Regards
0 -
- @eremitaitoPosted about 1 year ago
to center de container, use flexbox
body { min-height: 100vh; display: flex; align-items: center; justify-content: center; } i used min-height because the flex would recoginize as a box and center it
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord