
Design comparison
Solution retrospective
The biggest challenge for me was getting the page to have no background when viewed on mobile. With some research I was able to get it there.
What specific areas of your project would you like help with?Open to all kinds of feedback. Mostly if code is readable and makes sense. If there are things I could improve, I would love to hear them.
Community feedback
- P@cookie-monster01Posted 4 months ago
Hi, a few things that might be helpful.
-
CSS reset is super helpful to remove browser built-in styles. You can look into CSS reset by Andy Bell or by Josh W Comeau.
-
It is a best practice to use max-width of 736px, instead of width.
-
In the code below you can replace <span> with <strong>. So you don't have add styles for the same. <strong> element makes the text bold.
<li><span>Beat the eggs:</span> ... </li>
-
As px is a hard coded, it is a best practice to use units such as em or rem for padding and margins. And also, rem for font-size.
-
div.line can be avoided, you could give padding and then border. I also tried using <hr> for horizontal-line but I couldn't change its thickness and color.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord