Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML CSS QR component

@Olebxgeng

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Which areas of your code are you unsure of? Unsure of whether I formatted my css correctly. Any advice/feedback welcome :)

Community feedback

dimar hanungβ€’ 560

@dimar-hanung

Posted

Hello πŸ‘‹, Great job on complete the challenge! πŸŽ‰

I have some interest and feedback with your code

That i like:

  1. I appreciate the similarity of your results with the design, a bit different in position and font because footer, but still good
  2. html is pretty good, not too nested with combination semantic html πŸ‘
  3. CSS Naming is also good, represent what is it for, likeΒ <div class="qr-code">Β for qr code section
  4. Responsive until galaxy fold screen size πŸ‘Œ

My Feedback:

  • Maybe you can use tools like prettier to format your code to be more beautiful ( TIP: set prettier configuration to format on save, make it easier )

  • You can make it center using grid, make body styles into this

    body {
      font-family: "Outfit", sans-serif;
      background-color: hsl(212, 45%, 89%);
      margin: auto auto;
      display: grid;
      place-items: center;
      min-height: 100vh;
    }
    
  • you can seperate file by folder to be more structured ( just developer preference, not a rule), for example:

    public/
    β”œβ”€ images/
    β”‚  β”œβ”€ qr-code-image.png
    β”œβ”€ styles/
    β”‚  β”œβ”€ main.css
    β”œβ”€ favicon.png
    index.html
    
    

anyways overall is good, nice solution, hope it useful πŸ™Œ

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord