Design comparison
Solution retrospective
Which areas of your code are you unsure of? Unsure of whether I formatted my css correctly. Any advice/feedback welcome :)
Community feedback
- @dimar-hanungPosted over 1 year ago
Hello π, Great job on complete the challenge! π
I have some interest and feedback with your code
That i like:
- I appreciate the similarity of your results with the design, a bit different in position and font because footer, but still good
- html is pretty good, not too nested with combination semantic html π
- CSS Naming is also good, represent what is it for, likeΒ
<div class="qr-code">
Β for qr code section - Responsive until galaxy fold screen size π
My Feedback:
-
Maybe you can use tools like prettier to format your code to be more beautiful ( TIP: set prettier configuration to format on save, make it easier )
-
You can make it center using grid, make body styles into this
body { font-family: "Outfit", sans-serif; background-color: hsl(212, 45%, 89%); margin: auto auto; display: grid; place-items: center; min-height: 100vh; }
-
you can seperate file by folder to be more structured ( just developer preference, not a rule), for example:
public/ ββ images/ β ββ qr-code-image.png ββ styles/ β ββ main.css ββ favicon.png index.html
anyways overall is good, nice solution, hope it useful π
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord