html, css projcet : 3-column preview card component

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hello there, minthing! 👋

  Well done on this challenge! 👍

  A few things I'd like to suggest are,

  • Perhaps using an anchor tag (rather than the <button> element) for the "Learn More" elements on the page (since they seem like they will take the user somewhere when clicked).
  • Also perhaps using an <article> tag for the card itself and using some heading tags for the titles inside the card to make your HTML more semantic (which is good for things like SEO and accessibility).
  • Allowing the card component to be a little wider in the mobile layout (as long as there's room) would be nice. 😉

  Keep coding (and happy coding, too)! 😁

  3

  ---

  

  minthing•145

  @minthingPosted over 3 years ago

  @ApplePieGiraffe Thank You for great suggestion! Yes! the button is perhaps a link, so <a>is more make sense than button and i'll try <article>! thank you! 🙏

  i fixed it thank you so much!! :)

  0
• 

  Yudi Yoshida•350

  @yudiyoshidaPosted over 3 years ago

  Nice Work!!!

  0

  ---

  

  minthing•145

  @minthingPosted over 3 years ago

  @yudiyoshida Thank You!! 🙏

  0