Design comparison
Solution retrospective
I am just a newbie developer learning to build websites and this is my first project. Any type of suggestions and comments are welcome. Please suggest me some ways how to make my future projects responsive because that's where I got mainly stuck while doing different projects. Thank You.
Community feedback
- @grace-snowPosted almost 4 years ago
Hi there
Just a few points for improvement
- you don't need alt text on the top and bottom circles, just leave the attribute empty
- the position of those circles isn't right in mobile at the moment and there's quite a lot of scroll on the page. You might find you get on better making those into background images, and if you add overflow hidden to the wrapper.
Nice semantic html structure and the ard itself looks great. Good job overall ☺
2@jarihant701Posted almost 4 years agoThank you for your suggestions I will surely improve on these things. Just one question are you suggesting that I should make those two background circles into a background image and then use that as background image?
0@grace-snowPosted almost 4 years ago@jarihant701 no I just meant use them as background images. You can have multiple bg images on one item, or you can place them inside pseudo-elements (that's what I did in my solution for this if you want to take a look ☺ https://www.frontendmentor.io/challenges/profile-card-component-cfArpWshJ/hub/profile-card-with-pseudo-backgrounds-and-accessible-list-577BPZiIm)
0 - @tboittinPosted almost 4 years ago
Hi Arihant, nice work here !
You missed the K in 1.4K :)
I don't see any issue with the destop version.
Keep us informed when you'll make the responsive version.
Cheers !
2@jarihant701Posted almost 4 years agoThank You for your comment. I forgot about that K I will update that surely. I am still learning on the responsive aspect of a site once I will learn that I will make this responsive any suggestions like how and where I can learn about the responsiveness? Because I have a 720p monitor currently so the design looks great on my monitor but it is not great on mobile or any different screen resolution. Thank You.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord