@vanzasetia
Posted
š Hi Tiago!
š Congratulations on finishing this challenge! I have done this challenge, and yes, the bubbles were hard to be positioned correctly š . I would recommend looking at the ApplePieGiraffe's solution, he has done a great job on taking care of those bubbles. āI have some feedback on this solution:
- Accessibility
- For any decorative images, each
img
tag should have emptyalt=""
andaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images. In this case, all images are decorative only, except the profile picture. - For the profile picture, use his name as the alternative text. To learn more about images, read the tutorial from W3C WAI.
- For the stats, the number should not be a heading. A heading tag is like a title in a document.
- For the stats, I would recommend using
ul
and wrapping each item withli
instead of usingdiv
. ā* Userem
or sometimesem
unit instead ofpx
. Usingpx
will not allow the users to control the size of the page based on their needs.
- For any decorative images, each
- Responsiveness
- You don't need to specify how much
height
andwidth
the card element. Let the content inside it control the height of the card and usemax-width
to limit the width of the card. By doing those two things, your card can shrink if needed. - For the
height
of the body element, it's the same as the card, let the content or element inside it control theheight
of thebody
element. The problem now, if you see your website on the mobile landscape (640px * 360px), the card is touching the top of the page (when it should be in the middle of the page).
- You don't need to specify how much
That's it! Hopefully, this is helpful!
Marked as helpful
@tiagocostarebelo
Posted
@vanzasetia Thank you so much for your inputs and time. I've updated the solution with your inputs and it makes sense. Will keep them in mind for the next challenges. Thanks again.
@vanzasetia
Posted
@tiagocostarebelo You're welcome! I notice that you put the word photo as the alternative text of the Victor Crest image. You don't need to put word, image, photo, picture, since you're already using img
tag.
Now the screen reader will pronounce it as the following: "Victor Crest photo, image"
<img src="./images/image-victor.jpg" alt="Victor Crest photo">
Marked as helpful