Design comparison
Solution retrospective
I wrote this in VS Code (1.7.1.2) and tested it in Firefox (104.0.2).
There is one break point at 62.5em (1000px); below this threshold, the mobile view appears with the hamburger menu, which functions with JavaScript.
In Chrome (105.0.5195.127), the styling for the SVGs in the footer (the logo and social media icons) do not appear as they should, so please view the deployment in Firefox. I will address this issue at a later date, but if anyone has any insights into why this has occurred, I would appreciate it.
I also plan to address the accessibly and HTML issues at a later date.
Update September 19, 2022: I fixed the accessibility and HTML issues found via the report on Frontend Mentor.
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi K Karr, how are you?
I really liked the result of your project, but I have some tips that I think you will like:
1- Document should have one main landmark, you could have put all the content inside the
maintag click here2- All page content should be contained by landmarks, you can understand better by clicking here: click here
We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.
Example:
native HTML5 reference elements:
<body> <header>This is the header</header> <nav>This is the nav</nav> <main>This is the main</main> <footer>This is the footer</footer> </body>ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:
<body> <div role="banner">This is the header</div> <div role="navigation">This is the nav</div> <div role="main">This is the main</div> <div role="contentinfo">This is the footer</div> </body>It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.
Link to read more about: click here
2- Why it Matters
Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.
HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.
Rule Description
It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.
Link to read more about: click here
The rest is great!!
Hope it helps...👍
Marked as helpful0@kkarrwritesPosted about 2 years ago@AdrianoEscarabote Thank you, Adriano, so much for your useful comment. Your resources were very helpful, and I was able to fix the accessibility issues that the Frontend Mentor report generated, including adding a <main> tag, which I was missing. Accessibility is definitely an area that I need to and am excited to learn more about. Thanks again!
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord