HTML CSS only. Desktop first.

Community feedback

• 

  Carolina Ceballos•5

  @CarolinaCballosPosted about 3 years ago

  Hola, buen trabajo! Ademas de las anteriores observaciones agregaría detalles como el color mas claro en aquello textos que no son principales, margenes y en los enlaces y botones un hover con cursor pointer.

  0
• 

  Victor R•5

  @victorraguinPosted about 3 years ago

  Hey! Nice Job !

  Maybe you can try with a flexbox on your .card (https://css-tricks.com/snippets/css/a-guide-to-flexbox/) ? If you can master this, it will be great for you later!

  And you can replace your max-width : 400px with a width : 400px for more space.

  Good continuation :)

  0

  ---

  

  Jan Blahout•70

  @JanBlahoutPosted about 3 years ago

  @victorraguin Hi,

  thank you for your feedback. Already did the second part, and put fixed width there. I will have to look into the flexbox :)

  Cheers!

  0
• Account deleted

  Hi,

  • You should remove .background from the css and add the background-image on the body instead;

  body {
    background-image: url(/images/pattern-background-desktop.svg);
    background-size: cover;
    background-repeat: no-repeat;
  }
  
  

  • Do that ^^^ and take things from there.

  The card seems to be tall and thin, thus the content inside it looks squashed and have no space, and as you resize it get even smaller in width.

  • I think you'd rather give the card suitable dimensions for desktop than not doing it, and take things from there.

  Keep coding👍.

  0

  ---

  

  Jan Blahout•70

  @JanBlahoutPosted about 3 years ago

  @thulanigamtee Thank you so much, you are awesome ! :)

  0