HTML CSS Only

Community feedback

• Account deleted

  Hey Hasan, congratulations on completing the challenge! You did a great job 😉

  Let me give you some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • remove all margin from white-card class
  • use flexbox to the body to center the card. Read here -> flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😁 by Travolgi

  Marked as helpful

  1

  ---

  

  HASAN KAMEL•10

  @HasanWaelPosted over 2 years ago

  @travolgi I think now the code is a lot better, take a look.

  1

  Account deleted

  @HasanWael now it's much better! Great work keep it up :)

  0
• 

  Satyam Jha•400

  @satyammjhaPosted over 2 years ago

  Great solution @HasanWael You can center the QR by using align-item: center to the CSS of the div containing the QR. Hope it will help you.

  Marked as helpful

  1

  ---

  

  HASAN KAMEL•10

  @HasanWaelPosted over 2 years ago

  @satyammjha Thanks, that worked!

  1