Skip to content
Submitted about 2 years ago

Html Css

Viktor Brychuk•40
@viktorqjk
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted about 2 years ago

    Hi @viktorqjk 👋, good job on completing this challenge! 🎉

    Here are some suggestions you might consider:

    With semantic tags:

    <body>
   <main class="card">
      . . .
   </main>
   <footer class="attribution">
      . . .
   </footer>
<body>
    • The container isn't centered correctly. You can use flexbox to center elements:
    body {
  width: 100%;
  min-height: 100vh;
  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
}

    Additionally, remove the margin to center the card correctly.

    .card {
    /* align-items: center; */
    /* margin-top: 8em; */
    /* margin-left: 44em; */
    . . .
}
.attribution {
    padding-top: 20px;
    . . .
}

    Links with more information:

    .

    • Improve alternative texts by adding descriptive text to the alt attribute of the images. The alt attribute enables screen readers to read the information about on-page images and will be displayed instead if an image file cannot load.
    • Try to use more descriptive names for your classes. I suggest you learn the BEM naming convention standard for CSS class names because increases the readability of front-end code and provides a modular structure. For example, the classes "p-1" and "p-2" do not say what they are.
    • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.

    I hope those tips will help you.

    Good job, and happy coding!

    1
    Viktor Brychuk•40
    @viktorqjkPosted about 2 years ago

    @MelvinAguilar Hello! Thank you for your reply.

    I'll try to improve my writing in the future.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord