Any feedback on how I can Improve my implementation is welcome
@anmolkapil
Posted
Congratulations for finishing your project. �🎉 Functionality works fine in your website.
But I noticed few things that you can try to fix.
When all items are expanded it overflows your main container. It would be better if you don't define a fixed height for the container.
Add some media queries to make it responsive
Marked as helpful
@Jos02378
Posted
Hey Jordan! Good job on making this solution.
I tried to open your solution on my phone and it seems that the text goes out of the card when I tried to expand the accordion. I would like to suggest you not setting the height explicitly using percentage, but using the property "height: auto" or "height: fit-content" so the text doesn't go out of the card when the accordion expands.
I hope this helps, good luck!
Marked as helpful
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
