HTML | CSS | Learning basics before I go for any frameworks

Community feedback

• 

  Hassan Moataz•1,860

  @hassanmoaaPosted 9 months ago

  Hello !

  Great Job solving the challenge mate congrats 🎉

  Some suggestions for improvements.

  For the font-size it's is better to use rems and ems.

  font-size: 13px;

  • i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:

  • Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.

  Which properties are affected?

  All of these properties must never ever be declared in pixels:

  • font-size
  • line-height
  • letter-spacing

  If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!

  • You should use ems, and rems for font-sizes would be better

  This article may help:

  https://fedmentor.dev/posts/font-size-px/

  ➖➖➖➖➖➖➖➖

  Other than that you're good, keep up the good work!

  ➖➖➖➖➖➖➖➖

  And for your learning journey i recommend mastering the fundamentals of HTML/CSS first! then dig deeper into CSS practice it everyday till you get confident with it and a good grasp of knowledge, then learn Javascript Master the fundamentals do some solo projects with it to check your understanding and when your comfortable with your using these three together building projects go learn a Js framework like React or whatever you like and is popular.

  So Don’t ever learn a framework without mastering the fundamentals first and practice your vanilla skills so you can understand the framework easily!

  Marked as helpful

  0
• 

  mericadev•80

  @mericadevPosted 9 months ago

  Continue practicing writing readable and clean html and css code. If you use frameworks as a shortcut you'll be doing a disservice to your self and learning journey. The fundamentals will help you transition into frameworks smoothyly. I learnt this the hard way trying to learn Javascript framework when I had not mastered my javascript fundamentals.

  You did great !

  Marked as helpful

  0