HTML, CSS, JS

Community feedback

• 

  Joshua•25

  @minimalsmPosted about 3 years ago

  Hey :-) just a couple of things I would fix:

  • your headings should be uppercase (you could do this using text-transform: uppercase; so you don't have to hardcode it)
  • on the live version the buttons are in cursive (seems to be the fallback, are the fonts being loaded and referenced correctly?)
  • having your main set to 85vw causes some overflow issues right before you hit the 48rem media query

  Marked as helpful

  0

  ---

  

  hoangnam-nguyen•115

  @hoangnam-nguyenPosted about 3 years ago

  @minimalsm Thank you very much! I have updated the solution after fixing the issues that you mentioned:

  • Uppercase headings
  • Fix my mistake in referencing the fonts
  • Set main's width to 80rem, this seems to fix the overflow issue

  0