Design comparison
Solution retrospective
This is my first challenge with Js and it's working but still not perfect. It was hard to get the mobile version to work and I ended up switching from flex to grid. The challenge asked to show an image and message when an invalid email is sent, and I wanted to remove the img and the alert for the user enter valid email. I tried onfocus on the input field but fired up as soon as the user click the button, so I made a second function targeting backspace or delete key to reset the input field. I'm sure there's an easier way to do this, I just couldn't find it. It's a fun challenge.
Community feedback
- @A-amonPosted over 3 years ago
Hey, good job! I don't think it's nice to add the error message as the input value. It would be better to add it as a small text below the input for e.g. As for the JS, it would be better to add class to change the style when there are errors, instead of change the .styles directly in JS. For e.g. adding .error class in JS then setting the styles in CSS.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord