Design comparison
Solution retrospective
there can be many mistakes, suggest me to sort that things out
Community feedback
- @tesla-ambassadorPosted about 3 years ago
Hey, this solution is so great! It works just fine! I am just going to address your HTML issues; 1.I think the report algorithm thought you are trying to map an element in your comments😂 but otherwise, if you are writing a comment in HTML, don't put the two hyphens after the exclamation mark, that's why the report algorithm was acting up. 2. When you are linking your HTML file to your JavaScript file, you don't need to add type after the script, it could just look like this For the accessibility issues.
- Your header tags must follow a consecutive header (h1, h2, h3...) they should increment by one.
- Your form elements must have an label (this is for guys that use screen readers) you can add the labels and make them invisible buy setting their position to absolute and offset them to like 10000px to the right or left, just so that they can not be viewed in the browser. Otherwise I think this is a really great solution, kudos! Keep on coding.
Marked as helpful0@bwritamPosted about 3 years ago@tesla-ambassador thanks for these useful knowledges :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord