html css js dom model

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted about 3 years ago

  Hey, well done on completing the challenge! it looks fine but there's a few improvements you could make!

  1. Your email validation doesn't work properly, it lets my submit invalid email addresses. You should use a regex to check the input to cover most use cases ^^

  2. Terms&services should be a clickable link.

  3. The "pricing" and "form-container" are different widths, it would look nicer if they were the same.

  4. Your button is missing a cursor: pointer.

  5. You could set a max-width on your elements instead of width. Instead of % for widths rem would be a more reliable choice.

  6. You could center your container.

  Overall, good job, there are just some fixes needed :)

  Marked as helpful

  1

  ---

  

  Vishal Kumar•210

  @LahsivK4070Posted about 3 years ago

  @FluffyKas thanks for suggestions. Will improve the solution. Thanks

  0
• 

  SatVeer Singh•270

  @isatveersinghPosted about 3 years ago

  you should use functions to avoid repetative code. also you can use regular expressions for email validation.

  0

  ---

  

  Vishal Kumar•210

  @LahsivK4070Posted about 3 years ago

  @isatveersingh surely will keep that in mind. Thanks

  1