Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Natalia, good job! I took some time to look at your code and have some ideas for improving it:
- add
main
tag and wrap the content of page for improve the Accessibility img
element must have analt
attribute, it's very important!- instead
p
for the list of data of country you can useul
element - if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
- I would also add a query reset button, I find it very convenient
- in the details page Border Countries are missing
- dark mode does not work, you can add a
function
that to the click adds the.dark
class to the body and write the cssbody.dark
for the dark mode
Overall you did well 😉
Hope this help and happy coding!
Marked as helpful0 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord