HTML, CSS, JS

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, elalmamia! 👋 Well done on this challenge! It is really well done. I really like the box animation on hover.

  • Try to work on the proper class naming. Your classes aren't descriptive and also hard to read in the code. One of many benefits of proper class naming is that you know what to expect from a certain class without looking at code, even if you aren’t the person who created it or if it was written a long time ago. The name of a selector should be self-descriptive and readable. For example .card-right can be name .accordion etc.
  • Add :focus pseudo class to interactive elements like anchors, buttons and inputs in your case. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.

  Keep up the good work! 💪

  0

  ---

  

  elalmamia•90

  @elalmamiaPosted over 3 years ago

  @tediko Thanks for the hints! Really appreciate it!

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  Looks good ⭐⭐⭐⭐⭐

  0

  ---

  

  elalmamia•90

  @elalmamiaPosted over 3 years ago

  @palgramming thank you!

  0
• 

  Abhishek Rawat•690

  @AbePlaysPosted over 3 years ago

  Definitely doesn't look like a newbie's work. Good job!

  0

  ---

  

  elalmamia•90

  @elalmamiaPosted over 3 years ago

  @AbePlays Nice to hear that. Thank you!

  0