@Bishalsnghd07
Posted
Hi, @Neewrd12👋
Congrats for completing this challenge 🎉
A few suggestions for you:
1)I view your code, some CSS basics error caught, you have been used text-align property directly in your body, this is not a good practice, for good practice and better approach, I would recommend to use text-align in child component. Also, you can test your webpage by inspecting your web page and then you will see lighthouse option, just clicking on that test the performance of your web page by your own to enhance your skills in frontend development. Also, Lighthouse testing will test your overall result like, Accessibility test, best practices test, performance of your web page and SEO, it simplify our work as a developer and also you mentioned lighthouse hope you used it.
2)I would recommend to add, min-height in body, so your whole component will take the entire size of your whole screen, right now your screen height is taking your child height which is not good practice. For, example if you work with 3 to 4 layout in your web page, and end layout height would be 90 vh, then your normal screen size will be prevent to display the whole size, it will only display height: 90vh; and your original size of screen will be 100vh. So, in that case your layout will break. That's why I'm saying using min-height: 100vh in body of web page would be best practice and maintain the code flow and code quality as well.
Hope, this feedback will help you!
Happy coding❤️
