HTML CSS JS

Community feedback

• 

  Joseph•770

  @Jos02378Posted about 3 years ago

  Hey @nottohave, good job on this solution!

  Some suggestions for you:

  1. For the space problem of the card, you can fix it by not setting a fixed height on the card. You can use a min-height or not setting the height at all so your card can grow as your content grows.
  2. For centering the card, you can try to use margin: 0 auto.
  3. You can improve your method of creating the accordion by watching this video watch the video
  4. You can try to follow a CSS naming convention called BEM. You can watch this video for more information Watch the video.
  5. You can try to use relative units like em in the future. Here is a link to an article that explains when to use which unit see the article.

  I hope this helps, good luck!

  Marked as helpful

  0

  ---

  

  Cacti•390

  @nottohavePosted about 3 years ago

  @Jos02378 Thanks for the insights. I never find design this difficult. I think I will watch the videos and rethink my design. It looks like once I add the margin: 0 auto. Some of the short questions in my card shifted because it has flex and justify content space between. I tried text align left but it doesn't work. Would there be anyway to work on the text alone or it just the way it is?

  0

  

  Joseph•770

  @Jos02378Posted about 3 years ago

  Hey @nottohave, I don't entirely understand your question. What do you mean by your questions are shifted? Is it shifted in desktop size or mobile size? I tried adding margin: 0 auto to the card and the questions are not shifted both mobile and desktop. Did you add the margin to the section element with the class of card?

  0

  

  Cacti•390

  @nottohavePosted about 3 years ago

  Hey Jos02378, thanks for the comment. First time I add margin: 0 auto to * { } and not section element class of card. I think that's why it causes the shift on the questions on both mobile and desktop view. I still haven't found time to watch and think about the links you sent. I will see if I can find any interests on it.

  0