html , css, js

Community feedback

• 

  Amon•2,560

  @A-amonPosted over 3 years ago

  Hello! Good work~

  I have a few suggestions:

  1. The responsiveness seems off for view size of 650 ++ based on dev tools. Try using flexbox or grid for this project instead of just position:absolute almost everything.

  2. The image also seems compressed when on certain sizes. But I think it will naturally be solved when you learn how to use flexbox or grid~ Also, you can try using picture tag for switching between mobile and desktop images.

  3. Use a form tag for the .fake input instead of a div so that I can press Enter to submit too!

  4. Instead of using .main, try using the main tag directly.

  5. Instead of directly setting the styles in JS for your button's backgroundImage and boxShadow, since you have already added .error-image class to the input, use the + sibling selector in CSS.

  Good luck!

  Marked as helpful

  2

  ---

  

  Writam Biswas•105

  @bwritamPosted over 3 years ago

  @A-amon thank you very much. I will try flex.

  0

  

  Amon•2,560

  @A-amonPosted over 3 years ago

  @bwritam Glad to help!

  0
• 

  Aman Patil•885

  @Amanpatil-DevPosted over 3 years ago

  Nice job Writam 👍 Looks good and responds well too

  Marked as helpful

  0

  ---

  

  Writam Biswas•105

  @bwritamPosted over 3 years ago

  @Amanpatil-Dev thank you

  1
• 

  MOHD. AQUIB•115

  @aquibkhnPosted over 3 years ago

  Hey, you build this very well, but still needs some improvements like the button moving with the width, and also it looks weird on around 900px.

  Marked as helpful

  0

  ---

  

  Writam Biswas•105

  @bwritamPosted over 3 years ago

  @aquibkhn please share some tips where i can find the way out to solve the problem

  0