Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML CSS Js

AlbanDavid494β€’ 40

@AlbanDavid494

Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello guys, Am open for review centralizing this container is a bit difficult for me despite the fact i used display:flex, text-align:center, align-items:center, the social media icon wasn't centralize i need a review guys. thanks

Community feedback

Olaniyi Ezekielβ€’ 7,600

@Ezekiel225

Posted

Hello there πŸ‘‹ @AlbanDavid494.

Good job on completing the challenge !

Your project looks really good!

I have a suggestion about your code that might interest you:

πŸ“ŒThe reason why your project is not centralized is because you did not add the display: flex; justify-content: center; .... to the body element

πŸ“Œ Apply this to the body element (in order to work properly, don't use position or margins):

body {
    min-height: 100vh;
    display: flex;  /* it works with grid too  */
    justify-content: center;
    align-items: center;
}

πŸ“ŒUse <main> to wrap the main content instead of <div>.

Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.

πŸ“ŒIf you don't have the Figma design files, I recommend using a browser extension called Perfect Pixel.

It allows you to compare your finished project with the design images that come along when you download the project and check the (almost exact) dimensions. It's very useful!

I hope this suggestion is useful for future projects.

Other than that, great job!

Keep up the excellent work and continue to challenge yourself with new projects. Your progress is impressive, and each project is a step forward in your front-end development journey! πŸš€πŸŒŸ.

Happy coding.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord