Design comparison
SolutionDesign
Solution retrospective
Your opinion matters to me. Please provide your feedback so I can improve. Many Thanks.
Community feedback
- @elidrissidevPosted about 3 years ago
Hello Mahmoud π You've done a great job with your solution, It looks good on all screen sizes and design comparison shows only very little differences!
Here are some things to improve:
- Consider taking a look at the Report page of your solution when you submit it, it will help you identify problems and fix them.
- Your page lacks a level-one heading (
h1
). It is very important for SEO and even accessibility reasons to have one in every page of any site. In cases where the heading in not part of the design (like here), you can include it but make it visually hidden. Additionally, because you're usingarticle
tag for the reviews, this element requires a heading inside, so you can make all the review titles anh2
. Remember to always follow heading levels on your page from 1 to 6, don't skip them! - The text of the reviews is quoted from their authors. So wrapping the text of the reviews inside a
blockquote
element is more correct semantically. - This one might be a bit more of a personal preference, but I'd lean to using classes more and avoid selecting elements directly in CSS, this makes styles easier to read and more re-usable.
This is all the feedback I have, I hope it was helpful. Good luck!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord