HTML, CSS, JavaScript, Responsive Design, Accessibility

Community feedback

• 

  Atif Iqbal•3,200

  @atif-devPosted about 1 year ago

  Hi, congrats🎉 on completing the challenge. Better take about following points:

  • It is preferred to use em for padding and margin and rem for font-size. Watch here
  • When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.
  • In README file of your GitHub project's solution remove already present content and write about your own working flow, findings, new learned things, useful resources, etc.
  • There should also be hover states on social icons.
  • When we open project preview page first time, just click in input field and then click on anywhere on the screen. You will see email error whereas invalid message should display on button press only.

  --Got any questions, REPLY--

  Hope you will find this Feedback Helpful.

  Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub

  Marked as helpful

  1

  ---

  

  Julie_Gz•450

  @Julie-GzPosted about 1 year ago

  @atif-dev Thank you! I found your feedback very helpful. i wasn't aware of the about section on the github repository link, I'll check that out. Your other points are also helpful for future projects. Thanks again :)

  0