Pricing component with toggle with HTML5, CSS3 and JavaScript

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Hey Van, nice work on this challenge! Using JS to complete it is absolutely fine. Your JS code looks good too. One small thing is I'd set the elements to display block as opposed to inline-table but that's a really small thing.

  One larger change I'd recommend making would be to avoid using visibility: hidden; for the toggle input. Using it hides the element for screen reader users, so it makes the element inaccessible to people using assistive technologies to navigate the page. Here's a great tactic for hiding content in an accessible way.

  I hope that helps. Keep up the great work!

  1

  ---

  

  Van Ribeiro•225

  @vanribeiroPosted almost 5 years ago

  @mattstuddert, thank you about your feedback! It is really important to me! 😊 **About block/inline-table - ** I tried to set the property with block but when I run the code it isn't working nice. Maybe because I use a table structure to show the prices datas. The only it was running ok it was the inline-table... 🤷😅 **About visibility: hidden- ** I really liked this hint and I updated my code! Thank you very much again!

  1

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  @vanribeiro ah OK. I didn't see that you were using a table layout. It makes sense now.

  1

  

  Van Ribeiro•225

  @vanribeiroPosted almost 5 years ago

  @mattstuddert 😊

  0