Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

html css javascript

saskue7 170

@saskue7

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

romila 3,570

@romila2003

Posted

Hi @saskue7,

Congratulations 🎉 for completing another challenge, the card looks great and is responsive. There are some issues I want to address and some suggestions regarding your design:

  1. It is best practice to wrap the main content within the main tag which would ensure that your content is wrapped within the correct landmarks e.g. <main class="container"></main>
  2. Your fonts are missing the correct font-family property.
  3. For the border of the input field, you can give use 1px instead of 2px as the design has a lighter coloured aesthetic.
  4. You can use the form semantic to wrap the input instead of a regular div.
  5. Within your field, I noticed that the name and id attribute are left empty which has caused HTML issues.

Overall, great attempt and wish you the best for your future projects so keep coding 👍.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord