Design comparison
Solution retrospective
Hey π !
On this project I used gsap and I also tried to do unit tests but I am not yet familiar.
all comments and suggestions are welcome
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Hello, Elise Rousseau! π
Great job on this challenge, too! π Once again, the animations are a nice touch, and everything looks and works well! π
I think adding a little bit of margin to the sides of the accordion card would be a good idea so that there's some space between the card and the edges of the screen when the width of the screen decreases.
Also, switching to a mobile-friendly layout slightly sooner might be worth considering so that the text of the FAQs doesn't overflow into the image on the left of the card. π
Keep coding (and happy coding, too)! π
1@SarahHenriettePosted over 3 years ago@ApplePieGiraffe Hey π,
Thank you very much, for your always relevant suggestions π
1@ApplePieGiraffePosted over 3 years ago@SarahHenriette
Of course! π Keep going with these projects! π
1 - @samuelpalaciosdevPosted over 3 years ago
Hello again, Eliseπ
Well done on this challenge! Your solution looks good and it scales pretty well.π
I only suggest a little thing π:
- Decreasing the transition timing when opening the question. I'd change it to .3s, it makes it feels more smoother.
I really like the way you approach this, have a nice day, keep coding!π
1@SarahHenriettePosted over 3 years agoHey Samuel π,
Thank you very much for your comment, it makes me really happy π
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord