Design comparison
Solution retrospective
Any comment would be very appreciated. Thank You.
Community feedback
- @RocTanweerPosted over 3 years ago
Wonderful! The effect you gave on hovering the nav links was awesome! The automatic carousel effect was also awesome but when I am clicking on the numbers to see the first slide, for example, I don't know why but it seems like the automation of carousel gets broken. Unlike before, it's changing the slide without any delay...
Beside this, everything seems cool! Hope it helps! Happy coding!
0 - @pikapikamartPosted over 3 years ago
Hey some issues about your work.
- The slider just goes from normal speed to super fast when I click a slider button. I check your js, the timeout of 4000s is okay, i'm guessing that is caused by the event listener, the
onclick
that you put on those spans, when it is clicked, triggers the function, but, knowing that is is recursion, an event overlaps the functions then triggers both 2 at the same time, and I click 3 times. It runs 3 simultaneously. Refactoring that will make it good. - Paddings. There are sections where padding is not consistent, example is the footer. From the main page compared to the about page, it changes, from its left padding.
- In the contact page, a scrollbar from bottom is visible. This was cause by the text in the
.tell-us
class. It's width overlaps the body's width and therefore, a scrollbar appears at the bottom
0@pikapikamartPosted over 3 years ago@joni475 Remember to commit it so that we can see it as well^
0@joni475Posted over 3 years ago@pikamart Will do and thank you for taking time to check my code.
0@pikapikamartPosted over 3 years ago@joni475 Well everyone helps everyone here^
0 - The slider just goes from normal speed to super fast when I click a slider button. I check your js, the timeout of 4000s is okay, i'm guessing that is caused by the event listener, the
- @tushar416Posted over 3 years ago
AWESOME!!!!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord