Design comparison
Solution retrospective
Hey guys I am kind of new.. I had problems with my range slider's color changing when I inspected the site.... plus a few more other problems. Think you could help?
Community feedback
- @BurritoDoggiePosted over 3 years ago
hey! You changed a bunch of things that are pretty obvious like the 'monthly billing' and the 'yearly billing'. I think fixing them would be good. But everything else is pretty cool:).
Keep Coding!
(@@) \__/
2 - @ApplePieGiraffePosted almost 4 years ago
What's up, Tesla_Ambassador? π
Congratulations on completing your first Frontend Mentor challenge! π I knew you could do it! π Great effort on this challenge! π
For a small component such as this one, I suggest using an
<article>
tag for the component card itself and not using any<section>
tags inside of the card component (since those require a heading to identify them and they are generating some errors on your solution report).I also think you should a label to the slider (or identify it in some other way) to make your solution more accessible. π
As for the design, if you make the card component a little wider, you'll have more space to position the contents of the card more like the original design (and prevent some line breaks in places like "Monthly Billing" and "Yearly Billing" or the discount tag).
And for some next steps, you could work on getting the functionality of the monthly/yearly toggle-switch. π
We all get better with practice, so keep it up! π
And dude, you knowβkeep coding (and happy coding, too)! π
2 - @tesla-ambassadorPosted almost 4 years ago
Arigato sensei So I guess there was a bunch of stuff I missed out but thanks for pointing those things out am going to make corrections to my code bro! It was kind of a hustle to post it but thanks for the help Happy coding too and I will let you know as soon I as I correct my code (laughing emoji)
1@ApplePieGiraffePosted almost 4 years ago@tesla-ambassador
Haha, no problem! π
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord